[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1255537247-17208-1-git-send-email-dave@sr71.net>
Date: Wed, 14 Oct 2009 09:20:47 -0700
From: Dave Hansen <dave@...1.net>
To: dave@...1.net
Cc: linux-kernel@...r.kernel.org, Richard Purdie <rpurdie@...ys.net>,
Javier Martinez Canillas <martinez.javier@...il.com>
Subject: [PATCH] leds-ss4200: Check pci_enable_device return
pci_enable_result is defined using the __must_check macro but
leds-ss4200 is not checking the return value.
Cc: Richard Purdie <rpurdie@...ys.net>
Signed-off-by: Javier Martinez Canillas <martinez.javier@...il.com>
Signed-off-by: Dave Hansen <dave@...1.net>
---
drivers/leds/leds-ss4200.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c
index 0ec4ec3..c7f6347 100644
--- a/drivers/leds/leds-ss4200.c
+++ b/drivers/leds/leds-ss4200.c
@@ -344,10 +344,14 @@ static struct pci_dev *nas_gpio_pci_dev;
static int __devinit ich7_lpc_probe(struct pci_dev *dev,
const struct pci_device_id *id)
{
- int status = 0;
+ int status;
u32 gc = 0;
- pci_enable_device(dev);
+ status = pci_enable_device(dev);
+ if (status) {
+ dev_err(&dev->dev, "pci_enable_device failed\n");
+ return;
+ }
nas_gpio_pci_dev = dev;
status = pci_read_config_dword(dev, PMBASE, &g_pm_io_base);
--
1.6.5.rc2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists