linux-kernel - Re: [tip:bkl/drivers] drivers: Remove BKL from misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091014175846.GA3537@elte.hu>
Date:	Wed, 14 Oct 2009 19:58:46 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	gregkh@...e.de, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:bkl/drivers] drivers: Remove BKL from misc_open


* Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> On Wed, 14 Oct 2009 15:47:39 GMT
> tip-bot for Thomas Gleixner <tglx@...utronix.de> wrote:
> 
> > Commit-ID:  40b798efe3460797a4ac928ee2e038774e2758eb
> > Gitweb:     http://git.kernel.org/tip/40b798efe3460797a4ac928ee2e038774e2758eb
> > Author:     Thomas Gleixner <tglx@...utronix.de>
> > AuthorDate: Sat, 10 Oct 2009 15:35:43 +0000
> > Committer:  Thomas Gleixner <tglx@...utronix.de>
> > CommitDate: Wed, 14 Oct 2009 17:33:32 +0200
> > 
> > drivers: Remove BKL from misc_open
> > 
> > misc_open() is already serialized with misc_mtx. Remove the BKL
> > locking which got there via the BKL pushdown.
> 
> NAK.
> 
> You can't simply assume the mutex is enough - you have to either push 
> it down or review *every* possible called point below the lock_kernel 
> take.
> 
> In this case the open method of the misc devices below sometimes uses 
> the BKL.

We did that and it's safe in nvram.c. If you know an unsafe please let 
us know.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/