linux-kernel - RE: [PATCH 13/16] percpu: remove per_cpu_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0910141420300.9708@gentwo.org>
Date:	Wed, 14 Oct 2009 14:22:07 -0400 (EDT)
From:	Christoph Lameter <cl@...ux-foundation.org>
To:	"Luck, Tony" <tony.luck@...el.com>
cc:	Tejun Heo <tj@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rusty@...tcorp.com.au" <rusty@...tcorp.com.au>,
	"mingo@...hat.com" <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>,
	"hpa@...or.com" <hpa@...or.com>,
	"cebbert@...hat.com" <cebbert@...hat.com>
Subject: RE: [PATCH 13/16] percpu: remove per_cpu__ prefix.

On Wed, 14 Oct 2009, Luck, Tony wrote:

> But that would leave no visual indicator in the source
> code that a per-cpu variable was being used.  E.g. in
> delayed_tlb_flush() we'd end up with:

we would still have to use per cpu operations to get to the contents of
these variables.
>
>    if (unlikely(ia64_need_tlb_flush)) {

     if (unlikely(this_cpu_read(ia64_need_tlb_flush))
>        spin_lock ...
>        if (ia64_need_tlb_flush) {

	ditto.

>            local_flush_tlb_all();
>            ia64_need_tlb_flush = 0;

		this_cpu_write(ia64_need_tlb_flush, 0);
>        }
>        spin_unlock ...
>    }
>

Hope that addresses your concerns.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/