| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <tkrat.97d03c31313cb391@s5r6.in-berlin.de> Date: Wed, 14 Oct 2009 20:37:36 +0200 (CEST) From: Stefan Richter <stefanr@...6.in-berlin.de> To: linux1394-devel@...ts.sourceforge.net cc: linux-kernel@...r.kernel.org Subject: [PATCH 1/2] firewire: core: WARN on wrong usage of core transaction functions In the code path which creates request packets, clearly mark a switch branch which must never be reached with a WARN. In the code path which creates response packets, replace a BUG by a friendlier to debug WARN. Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de> --- drivers/firewire/core-transaction.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) Index: linux-2.6.31/drivers/firewire/core-transaction.c =================================================================== --- linux-2.6.31.orig/drivers/firewire/core-transaction.c +++ linux-2.6.31/drivers/firewire/core-transaction.c @@ -218,6 +218,9 @@ static void fw_fill_request(struct fw_pa packet->header_length = 16; packet->payload_length = 0; break; + + default: + WARN(1, KERN_ERR "wrong tcode %d", tcode); } common: packet->speed = speed; @@ -595,8 +598,7 @@ void fw_fill_response(struct fw_packet * break; default: - BUG(); - return; + WARN(1, KERN_ERR "wrong tcode %d", tcode); } response->payload_bus = 0; -- Stefan Richter -=====-==--= =-=- -===- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists