linux-kernel - Re: [PATCH 13/13] [PATCH 13/13] perf tools: remove all char * typecasts and use const in prototype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091014202600.GA5133@nowhere>
Date:	Wed, 14 Oct 2009 22:26:02 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 13/13] [PATCH 13/13] perf tools: remove all char *
	typecasts and use const in prototype

On Wed, Oct 14, 2009 at 03:43:44PM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <srostedt@...hat.com>
> 
> The (char *) for all the static strings was a fix for the symptom and
> not the disease. The real issue was that the function prototypes
> needed to be declared "const char *".
> 
> Signed-off-by: Steven Rostedt <srostedt@...hat.com>
> ---


Yep.
I know it's a shame what I did. I was just harassed by tons of
warnings when I integrated trace-cmd into perf (because of its gcc
flags) and then I was too impatient and did the wrong thing :)

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/