linux-kernel - Re: [PATCH 14/16] percpu: make access macros universal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AD6EB08.9070303@kernel.org>
Date:	Thu, 15 Oct 2009 18:27:36 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Christoph Lameter <cl@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, rusty@...tcorp.com.au,
	mingo@...hat.com, tglx@...utronix.de, akpm@...ux-foundation.org,
	rostedt@...dmis.org, hpa@...or.com, cebbert@...hat.com
Subject: Re: [PATCH 14/16] percpu: make access macros universal

Christoph Lameter wrote:
> On Wed, 14 Oct 2009, Tejun Heo wrote:
> 
>> @@ -182,17 +185,19 @@ static inline void *pcpu_lpage_remapped(void *kaddr)
>>  #ifndef percpu_read
>>  # define percpu_read(var)						\
>>    ({									\
>> -	typeof(var) __tmp_var__;					\
>> -	__tmp_var__ = get_cpu_var(var);					\
>> -	put_cpu_var(var);						\
>> -	__tmp_var__;							\
>> +	typeof(var) *pr_ptr__ = &(var);					\
>> +	typeof(var) pr_ret__;						\
>> +	pr_ret__ = get_cpu_var(*pr_ptr__);				\
>> +	put_cpu_var(*pr_ptr__);						\
>> +	pr_ret__;							\
>>    })
>>  #endif
> 
> == this_cpu_read(var) ?

Yeah, all these extra and duplicate accessors need to go away.  Once
dust around this patchset settles down.  That's the next thing to do.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/