linux-kernel - Re: [PATCH v2] define convenient securebits masks for prctl users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091015141822.GB16162@us.ibm.com>
Date:	Thu, 15 Oct 2009 09:18:22 -0500
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	mtk.manpages@...il.com
Cc:	lkml <linux-kernel@...r.kernel.org>,
	"Andrew G. Morgan" <morgan@...nel.org>,
	Ulrich Drepper <drepper@...hat.com>
Subject: Re: [PATCH v2] define convenient securebits masks for prctl users

Quoting Michael Kerrisk (mtk.manpages@...glemail.com):
> Hi Serge,
> 
> On Wed, Oct 14, 2009 at 11:15 PM, Serge E. Hallyn <serue@...ibm.com> wrote:
> > The securebits are used by passing them to prctl with the
> > PR_{S,G}ET_SECUREBITS commands.  But the defines must be
> > shifted to be used in prctl, which begs to be confused and
> > misused by userspace.  So define some more convenient
> > values for userspace to specify.  This way userspace does
> >
> >        prctl(PR_SET_SECUREBITS, SECBIT_NOROOT);
> >
> > instead of
> >
> >        prctl(PR_SET_SECUREBITS, 1 << SECURE_NOROOT);
> >
> > Thanks to Michael for the idea.
> >
> > This patch also adds include/linux/securebits to the installed headers.
> > Then perhaps it can be included by glibc's sys/prctl.h.
> >
> > Changelog:
> >        Oct 14: (Suggestions by Michael Kerrisk):
> >                1. spell out SETUID in SECBIT_NO_SETUID*
> >                2. SECBIT_X_LOCKED does not imply SECBIT_X
> >                3. add definitions for keepcaps
> 
> Thanks for these changes.

Thanks for taking a look and commenting!

> >        Oct 14: As suggested by Michael Kerrisk, don't
> >                use SB_* as that convention is already in
> >                use.  Use SECBIT_ prefix instead.
> >
> > Signed-off-by: Serge E. Hallyn <serue@...ibm.com>
> > Acked-by: Andrew G. Morgan <morgan@...nel.org>
> 
> Acked-by: Michael Kerrisk <mtk.manpages@...il.com>

thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/