linux-kernel - Re: [patch 2/2] x86_64: align RODATA kernel section to 2MB with CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1255638228.2532.4.camel@sbs-t61>
Date:	Thu, 15 Oct 2009 13:23:48 -0700
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	"hpa@...or.com" <hpa@...or.com>, "mingo@...e.hu" <mingo@...e.hu>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"arjan@...ux.jf.intel.com" <arjan@...ux.jf.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Ma, Chinang" <chinang.ma@...el.com>
Subject: Re: [patch 2/2] x86_64: align RODATA kernel section to 2MB with
 CONFIG_DEBUG_RODATA

On Wed, 2009-10-14 at 20:24 -0700, Sam Ravnborg wrote:
> > +#else
> > +
> > +#define X64_ALIGN_DEBUG_RODATA_BEGIN
> > +#define X64_ALIGN_DEBUG_RODATA_END
> > +
> > +#endif
> 
> A coment describing the purpose of
> this would be nice.

I will update this in the next version of the patch.

> > @@ -726,9 +726,13 @@ void set_kernel_text_ro(void)
> >  
> >  void mark_rodata_ro(void)
> >  {
> > -	unsigned long start = PFN_ALIGN(_text), end = PFN_ALIGN(__end_rodata);
> > +	unsigned long start = PFN_ALIGN(_text);
> >  	unsigned long rodata_start =
> >  		((unsigned long)__start_rodata + PAGE_SIZE - 1) & PAGE_MASK;
> > +	unsigned long end = (unsigned long) &__end_rodata_hpage_align;
> Here the symbol seems to be referenced unconditionally.

This function is defined only for CONFIG_DEBUG_RODATA.

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/