linux-kernel - Re: [Bug #14388] keyboard under X with 2.6.31

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ljjce1ey.fsf@devron.myhome.or.jp>
Date:	Fri, 16 Oct 2009 07:29:41 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Oleg Nesterov <oleg@...hat.com>,
	Paul Fulghum <paulkf@...rogate.com>,
	Boyan <btanastasov@...oo.co.uk>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Ed Tomlinson <edt@....ca>
Subject: Re: [Bug #14388] keyboard under X with 2.6.31

Linus Torvalds <torvalds@...ux-foundation.org> writes:

> On Fri, 16 Oct 2009, OGAWA Hirofumi wrote:
>> 
>> I.e. the following or something,
>> 
>> static inline int input_available_p(struct tty_struct *tty, int amt)
>> {
>> 	int try = 0;
>> 
>> retry:
>> 	if (tty->icanon) {
>> 		if (tty->canon_data)
>> 			return 1;
>> 	} else if (tty->read_cnt >= (amt ? amt : 1))
>> 		return 1;
>> 
>> 	if (!checked) {
>> 		tty_flush_to_ldisc(tty);
>> 		try = 1;
>> 		goto retry;
>> 	}
>> 
>> 	return 0;
>> }
>
> Yeah, we could do that. Especially if we ever see this in any profiles. I 
> doubt we do, but..

Yes.  Or, FWIW, I was thinking to delete schedule_delayed_work() for
n_tty with flag or something at previous time.  I.e. disable background
flush_to_ldisc() by writer for n_tty, only n_tty_read() will check
tty.buf synchronously.

So, with it, unnecessary flush_to_ldisc() is removed completely... Well...

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/