linux-kernel - RE: [Xen-devel] [PATCH 05/12] xen/pvclock: add monotonicity check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0be3e26b-76b6-47c9-b7ab-51ed72b72b69@default>
Date:	Wed, 14 Oct 2009 20:26:48 -0700 (PDT)
From:	Dan Magenheimer <dan.magenheimer@...cle.com>
To:	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	Xen-devel <xen-devel@...ts.xensource.com>, kurt.hackel@...cle.com,
	the arch/x86 maintainers <x86@...nel.org>,
	Glauber de Oliveira Costa <gcosta@...hat.com>,
	Avi Kivity <avi@...hat.com>, chris.mason@...cle.com
Subject: RE: [Xen-devel] [PATCH 05/12] xen/pvclock: add monotonicity check

> Other tsc-based clocksources add a monotonicity test to make 
> sure there's
> no regression in the returned cycles.
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
> ---
>  arch/x86/xen/time.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
> index 0a5aa44..00f06cc 100644
> --- a/arch/x86/xen/time.c
> +++ b/arch/x86/xen/time.c
> @@ -213,9 +213,14 @@ cycle_t xen_clocksource_read(void)
>  	return ret;
>  }
>  
> +static struct clocksource xen_clocksource;
> +
>  static cycle_t xen_clocksource_get_cycles(struct clocksource *cs)
>  {
> -	return xen_clocksource_read();
> +	cycle_t ret = xen_clocksource_read();
> +
> +	return ret >= xen_clocksource.cycle_last ?
> +		ret : xen_clocksource.cycle_last;

As long as we are going through the trouble of making
this monotonic, shouldn't it be monotonically increasing
(rather than just monotonically non-decreasing)?  The
rdtsc instruction and any suitably high-precision
hardware timer will never return the same value
on subsequent uses so this might be a reasonable
precedent to obey.  E.g.

+	return ret > xen_clocksource.cycle_last ?
+		ret : ++xen_clocksource.cycle_last;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/