linux-kernel - Re: [PATCH v6 5/5]: mtdoops: refactor as a kmsg_dumper

Open Source and information security mailing list archives

Message-ID: <ce9ab5790910142211v54c70deet8c5732cfccb01914@mail.gmail.com>
Date:	Thu, 15 Oct 2009 10:41:39 +0530
From:	vimal singh <vimal.newwork@...il.com>
To:	Simon Kagstrom <simon.kagstrom@...insight.net>
Cc:	linux-mtd <linux-mtd@...ts.infradead.org>,
	Artem Bityutskiy <dedekind1@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Koskinen Aaro (Nokia-D/Helsinki)" <aaro.koskinen@...ia.com>,
	Ingo Molnar <mingo@...e.hu>,
	David Woodhouse <dwmw2@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH v6 5/5]: mtdoops: refactor as a kmsg_dumper

On Wed, Oct 14, 2009 at 8:42 PM, Simon Kagstrom
<simon.kagstrom@...insight.net> wrote:
> On Wed, 14 Oct 2009 15:41:24 +0200
> Simon Kagstrom <simon.kagstrom@...insight.net> wrote:
>
>> -static void __exit mtdoops_console_exit(void)
>> +static void __exit mtdoops_exit(void)
>>  {
>>       struct mtdoops_context *cxt = &oops_cxt;
>>
>>       unregister_mtd_user(&mtdoops_notifier);
>> -     unregister_console(&mtdoops_console);
>>       kfree(cxt->name);
>
> The kfree should go as well since cxt->name is no longer allocated. I'll
> await further comments and send a new patch tomorrow.
>
Help description for 'MTD_OOPS' in Kconfig needs update after this
patch. Are you planning to add a patch for same in this series?

-vimal

> // Simon
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives