linux-kernel - Re: [PATCH 6/7] checkpatch: fix false EXPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091016232612.GA23876@penfold>
Date:	Sat, 17 Oct 2009 00:26:12 +0100
From:	Andy Whitcroft <apw@...onical.com>
To:	Daniel Walker <dwalker@...o99.com>
Cc:	Andrew Morton <akpm@...l.org>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH 6/7] checkpatch: fix false EXPORT_SYMBOL warning

On Fri, Oct 16, 2009 at 11:58:21AM -0700, Daniel Walker wrote:
> On Fri, 2009-10-16 at 19:39 +0100, Andy Whitcroft wrote:
> 
> > -				WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
> > +#print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
> > +				$suppress_export{$realline_next} = 2;
> > +			} else {
> > +				$suppress_export{$realline_next} = 1;
> >  			}
> >  		}
> > +		if (!defined $suppress_export{$linenr} &&
> > +		    $prevline =~ /^.\s*$/ &&
> > +                    ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
> > +		     $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
> 
> ERROR: code indent should use tabs where possible
> #148: FILE: scripts/checkpatch.pl:1734:
> +                    ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||$
> 
> This one line is spaced over instead of tabbed.. I guess checkpatch can
> even check itself, which is nice .. I'm not sure this matters since this
> it's perl tho..
> 
> Do you apply any kind of coding style to checkpatch itself ?

Yeah normally I checkpatch it, and ignore the width issues as the long
regexps are not always sensibly wrappable.  I rushed this lot out as I
am travelling tommorrow.  Sigh.  Never rush out a set of patches.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/