linux-kernel - [tip:x86/urgent] x86: Don't print number of MCE banks for every CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-93ae5012a79b11e7fc855b52c7ce1e16fe1540b0@git.kernel.org>
Date:	Fri, 16 Oct 2009 07:22:27 GMT
From:	tip-bot for Roland Dreier <rdreier@...co.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	rdreier@...co.com, rolandd@...co.com, tglx@...utronix.de,
	mingo@...e.hu
Subject: [tip:x86/urgent] x86: Don't print number of MCE banks for every CPU

Commit-ID:  93ae5012a79b11e7fc855b52c7ce1e16fe1540b0
Gitweb:     http://git.kernel.org/tip/93ae5012a79b11e7fc855b52c7ce1e16fe1540b0
Author:     Roland Dreier <rdreier@...co.com>
AuthorDate: Thu, 15 Oct 2009 14:21:14 -0700
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Fri, 16 Oct 2009 09:20:03 +0200

x86: Don't print number of MCE banks for every CPU

The MCE initialization code explicitly says it doesn't handle
asymmetric configurations where different CPUs support different
numbers of MCE banks, and it prints a big warning in that case.

Therefore, printing the "mce: CPU supports <x> MCE banks"
message into the kernel log for every CPU is pure redundancy
that clutters the log significantly for systems with lots of
CPUs.

Signed-off-by: Roland Dreier <rolandd@...co.com>
LKML-Reference: <adaeip473qt.fsf@...co.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/cpu/mcheck/mce.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index b1598a9..721a77c 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1214,7 +1214,8 @@ static int __cpuinit mce_cap_init(void)
 	rdmsrl(MSR_IA32_MCG_CAP, cap);
 
 	b = cap & MCG_BANKCNT_MASK;
-	printk(KERN_INFO "mce: CPU supports %d MCE banks\n", b);
+	if (!banks)
+		printk(KERN_INFO "mce: CPU supports %d MCE banks\n", b);
 
 	if (b > MAX_NR_BANKS) {
 		printk(KERN_WARNING
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/