linux-kernel - Re: BUG? linux-mips flush_dcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Oct 2009 11:24:18 +0200
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Minchan Kim <minchan.kim@...il.com>
Cc:	Atsushi Nemoto <anemo@....ocn.ne.jp>,
	lkml <linux-kernel@...r.kernel.org>,
	linux-mips <linux-mips@...ux-mips.org>,
	Chungki woo <chungki.woo@...il.com>
Subject: Re: BUG? linux-mips flush_dcache_page

On Fri, Oct 16, 2009 at 02:17:19PM +0900, Minchan Kim wrote:

> Many code of kernel fs usually allocate high page and flush.
> But flush_dcache_page of mips checks PageHighMem to avoid flush
> so that data consistency is broken, I think. 

What processor and cache configuration?

> I found it's by you and Atsushi-san on 585fa724. 
> Why do we need the check?
> Could you elaborte please? 

The if statement exists because __flush_dcache_page would crash if a page
is not mapped.  This of course isn't correct but that wasn't a problem
since highmem still is only supported on machines that don't have aliases.

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/