linux-kernel - Re: [RFC Patch] use MTRR for write combining if PAT is not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200910172148.36267.thomas.schlichter@web.de>
Date:	Sat, 17 Oct 2009 21:48:36 +0200
From:	Thomas Schlichter <thomas.schlichter@....de>
To:	"Jan Beulich" <JBeulich@...ell.com>
Cc:	"Jeremy Fitzhardinge" <jeremy.fitzhardinge@...rix.com>,
	"Robert Hancock" <hancockrwd@...il.com>,
	"Henrique de Moraes Holschuh" <hmh@....eng.br>,
	"Suresh Siddha" <suresh.b.siddha@...el.com>,
	"Venkatesh Pallipadi" <venkatesh.pallipadi@...el.com>,
	"Tejun Heo" <tj@...nel.org>, x86@...nel.org,
	"Yinghai Lu" <yinghai@...nel.org>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Arjan van de Ven" <arjan@...ux.intel.com>,
	dri-devel@...ts.sourceforge.net, "Ingo Molnar" <mingo@...hat.com>,
	linux-kernel@...r.kernel.org, jbarnes@...tuousgeek.org,
	"Thomas Hellstrom" <thellstrom@...are.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [RFC Patch] use MTRR for write combining if PAT is not available

Jan Beulich wrote:
> >>> Thomas Schlichter <thomas.schlichter@....de> 14.10.09 21:14 >>>
> >
> >I added a function mtrr_add_unaligned() that tries to create as many MTRR
> >entries as necessary, beginning with the biggest regions. It does not
> > check the return values of each mtrr_add(), nor does it return the
> > indexes of the created MTRR entries. So it seems to be only useful with
> > increment=false. Or do you have a better idea?
> 
> I don't have immediate thoughts on how to address this, but nevertheless
> I continue to think that the issue must be solved in some way, even more
> that now you may be leaking multiple MTRRs.

OK, it required some changes on different edges, but now I have it...

Patches 0001-0003 introduce functionality/changes to the MTRR and sysfs 
subsystems. Patch 0004 is the main patch which sets up the MTRR entries when 
pci memory regions are mmapped. The Patches 0005-0006 also change ioremap() 
and set_mempry_wc() to set up MTRR entries. These two are completely optional, 
especially and there is currently no way to automatically remove MTRR entries 
set up with them.

What do you think about these patches?

Kind regards,
  Thomas

View attachment "0005-Use-MTRR-for-write-combining-ioremap.patch" of type "text/x-patch" (1368 bytes)

View attachment "0001-Add-new-mtrr_add_unaligned-function.patch" of type "text/x-patch" (2846 bytes)

View attachment "0002-Make-num_var_ranges-accessible-outside-MTRR-code.patch" of type "text/x-patch" (1636 bytes)

View attachment "0003-Provide-per-file-private-data-for-bin-sysfs-files.patch" of type "text/x-patch" (2813 bytes)

View attachment "0004-Use-MTRR-for-pci_mmap_resource_wc-if-PAT-is-not-avai.patch" of type "text/x-patch" (3530 bytes)

View attachment "0006-Set-up-MTRR-entries-within-set_memory_wc.patch" of type "text/x-patch" (1248 bytes)