linux-kernel - Re: [patch] fix driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Oct 2009 01:03:50 +0400
From:	Stas Sergeev <stsp@...et.ru>
To:	Greg KH <gregkh@...e.de>
CC:	Linux kernel <linux-kernel@...r.kernel.org>
Subject: Re: [patch] fix driver_register() return value

18.10.2009 00:46, Greg KH wrote:
>> Returning -EBUSY fixes the problem.
>> Signed-off-by: Stas Sergeev<stsp@...et.ru>
> Does this cause problems with the way things now are?  If so, what are
> they?
They are simple.
Suppose the pcspkr driver was loaded
by the udev. Then someone types:
modprobe snd-pcsp
and that doesn't print anything, so
he thinks the snd-pcsp was loaded and
asks me why there is no sound. :)
Only by typing "dmesg" you can see what
actually happened, but it would be better
to have that from modprobe too.

> Does this change need to be backported to older -stable kernels?
I think it can't hurt.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/