linux-kernel - [PATCH] UM: Remove BKL from sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 18 Oct 2009 16:36:16 +0200 (CEST)
From:	John Kacur <jkacur@...hat.com>
To:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
cc:	Arnd Bergmann <arndbergmann@...glemail.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Ingo Molnar <mingo@...e.hu>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jeff Dike <jdike@...toit.com>
Subject: [PATCH] UM: Remove BKL from sys_execve

>From 4d71a5e17b985a8fefaa88e3a6fe4896878886ba Mon Sep 17 00:00:00 2001
From: John Kacur <jkacur@...hat.com>
Date: Sun, 18 Oct 2009 16:17:57 +0200
Subject: [PATCH] UM: Remove BKL from sys_execve

The BKL in sys_execve is likely the result of a cut-and-paste from a time,
when it was needed. However, it is no longer required here. Remove to be
in sync with other architectures.

(See arch/x86/kernel/process_64.c for example)

Signed-off-by: John Kacur <jkacur@...hat.com>
---
 arch/um/kernel/exec.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/um/kernel/exec.c b/arch/um/kernel/exec.c
index fda30d2..d39aa36 100644
--- a/arch/um/kernel/exec.c
+++ b/arch/um/kernel/exec.c
@@ -5,7 +5,6 @@
 
 #include "linux/stddef.h"
 #include "linux/fs.h"
-#include "linux/smp_lock.h"
 #include "linux/ptrace.h"
 #include "linux/sched.h"
 #include "asm/current.h"
@@ -76,13 +75,11 @@ long sys_execve(char __user *file, char __user *__user *argv,
 	long error;
 	char *filename;
 
-	lock_kernel();
 	filename = getname(file);
 	error = PTR_ERR(filename);
-	if (IS_ERR(filename)) goto out;
+	if (IS_ERR(filename))
+		return error;
 	error = execve1(filename, argv, env);
 	putname(filename);
- out:
-	unlock_kernel();
 	return error;
 }
-- 
1.6.0.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/