lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4ADC6C67.8090206@monstr.eu> Date: Mon, 19 Oct 2009 15:40:55 +0200 From: Michal Simek <monstr@...str.eu> To: Tejun Heo <tj@...nel.org> CC: Christoph Lameter <cl@...ux-foundation.org>, linux-kernel@...r.kernel.org, rusty@...tcorp.com.au, mingo@...hat.com, Thomas Gleixner <tglx@...utronix.de>, akpm@...ux-foundation.org, rostedt@...dmis.org, hpa@...or.com, cebbert@...hat.com, tony.luck@...el.com Subject: Re: [PATCH 13/16] percpu: remove per_cpu__ prefix. Tejun Heo wrote: > (microblaze maintainer cc'd, hello) > > Christoph Lameter wrote: >> On Wed, 14 Oct 2009, Tejun Heo wrote: >> >>> @@ -39,7 +39,7 @@ extern void *per_cpu_init(void); >>> * On the positive side, using __ia64_per_cpu_var() instead of __get_cpu_var() is slightly >>> * more efficient. >>> */ >>> -#define __ia64_per_cpu_var(var) per_cpu__##var >>> +#define __ia64_per_cpu_var(var) var >> IA64 could completely drop the macro? Tony? > > Being discussed but I think we should just add sparse annotation there > instead. > >>> diff --git a/arch/microblaze/include/asm/entry.h b/arch/microblaze/include/asm/entry.h >>> index 61abbd2..ec89f2a 100644 >>> --- a/arch/microblaze/include/asm/entry.h >>> +++ b/arch/microblaze/include/asm/entry.h >>> @@ -21,7 +21,7 @@ >>> * places >>> */ >>> >>> -#define PER_CPU(var) per_cpu__##var >>> +#define PER_CPU(var) var >> Microblaze too. > > This macro is used only in assemblies which wouldn't be covered by > sparse so in this case this patch series actually removes protection, > so I wasn't too sure about ripping the macro off. Any ideas what we > can do here? Just kill it? If I understand correctly, functionality will be the same. But anyway I would like to mot lose information about per_cpu variables. That's why please keep that macro for Microblaze. If is the problem, you should convince me why to do it. Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists