linux-kernel - Re: [PATCH 3/7] crypto: testmgr: fix warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.00.0910191551030.8582@wotan.suse.de>
Date:	Mon, 19 Oct 2009 15:52:47 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Felipe Contreras <felipe.contreras@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	Jarod Wilson <jarod@...hat.com>,
	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>,
	Neil Horman <nhorman@...driver.com>,
	linux-crypto@...r.kernel.org
Subject: Re: [PATCH 3/7] crypto: testmgr: fix warning

On Mon, 19 Oct 2009, Felipe Contreras wrote:

> crypto/testmgr.c: In function ?test_cprng?:
> crypto/testmgr.c:1204: warning: ?err? may be used uninitialized in this function
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@...il.com>
> ---
>  crypto/testmgr.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> index 6d5b746..1f2357b 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -1201,7 +1201,7 @@ static int test_cprng(struct crypto_rng *tfm, struct cprng_testvec *template,
>  		      unsigned int tcount)
>  {
>  	const char *algo = crypto_tfm_alg_driver_name(crypto_rng_tfm(tfm));
> -	int err, i, j, seedsize;
> +	int err = 0, i, j, seedsize;
>  	u8 *seed;
>  	char result[32];

As it is not obvious to me immediately why/whether tcount couldn't be zero 
(which would cause uninitialized use of 'err'), I am not merging this 
through trivial tree. Herbert?

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/