lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <989292.58968.qm@web50112.mail.re2.yahoo.com> Date: Mon, 19 Oct 2009 07:58:24 -0700 (PDT) From: Doug Thompson <norsk5@...oo.com> To: Borislav Petkov <borislav.petkov@....com>, Doug Thompson <dougthompson@...ssion.com>, linux-kernel@...r.kernel.org, Li Hong <lihong.hi@...il.com> Subject: Re: [PATCH] amd64_edac: fix a wrong goto clause in amd64_edac.c --- On Mon, 10/19/09, Li Hong <lihong.hi@...il.com> wrote: > From: Li Hong <lihong.hi@...il.com> > Subject: [PATCH] amd64_edac: fix a wrong goto clause in amd64_edac.c > To: "Borislav Petkov" <borislav.petkov@....com>, "Doug Thompson" <dougthompson@...ssion.com>, linux-kernel@...r.kernel.org > Date: Monday, October 19, 2009, 2:33 AM > In amd64_edac_init(void) in > amd64_edac.c, cache_k8_northbridges() is called > before pci_register_driver. If it fails, should exit with > err directly. > > Signed-off-by: Li Hong <lihong.hi@...il.com> Acked-by: Doug Thompson <dougthompson@...ssion.com> > --- > drivers/edac/amd64_edac.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/edac/amd64_edac.c > b/drivers/edac/amd64_edac.c > index d4560d9..3ee539a 100644 > --- a/drivers/edac/amd64_edac.c > +++ b/drivers/edac/amd64_edac.c > @@ -3163,7 +3163,7 @@ static int __init > amd64_edac_init(void) > opstate_init(); > > if (cache_k8_northbridges() < 0) > - goto err_exit; > + return err; > > err = > pci_register_driver(&amd64_pci_driver); > if (err) > @@ -3189,8 +3189,6 @@ static int __init > amd64_edac_init(void) > > err_2nd_stage: > debugf0("2nd stage failed\n"); > - > -err_exit: > > pci_unregister_driver(&amd64_pci_driver); > > return err; > -- > 1.6.0.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists