linux-kernel - Re: [PATCH 1/3] scripts/get_maintainer.pl: Add patch/file search for keywords

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1255967250.24167.621.camel@Joe-Laptop.home>
Date:	Mon, 19 Oct 2009 08:47:30 -0700
From:	Joe Perches <joe@...ches.com>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Anton Vorontsov <avorontsov@...mvista.com>
Subject: Re: [PATCH 1/3] scripts/get_maintainer.pl: Add patch/file search
 for keywords

On Mon, 2009-10-19 at 11:41 +0200, Wolfram Sang wrote:
> > @@ -149,6 +153,8 @@ while (<MAINT>) {
> >  	    if ((-d $value)) {
> >  		$value =~ s@([^/])$@$1/@;
> >  	    }
> > +	} elsif ($type eq "K") {
> > +	    $keyword_hash{@...evalue} = $value;
> 
> It matches the way how the current implementation works, but I guess somewhen
> this @typevalue-array should be converted into a hash like
>	$types{$type} = $value;
> or similar unless I missed something.

I think you missed something.

What this is doing is saving the typevalue index of the
section where the keyword is specified.  That index is
used on the type match to add maintainers.

> Maybe the file should be read completely to save the loop.

I see if that matters.

> A bit unrelated: I noticed that lkml gets always added due to "F: *". Maybe
> this list should be skipped if there has been another mailing list found?

I think that get_maintainers is generally used by people
that aren't already sure who should get an email about 
a patch or file.  I think lkml should be cc'd in almost
every case when someone is not already sure where to
send something.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/