lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 20 Oct 2009 08:51:08 +0200 (CEST)
From:	Michael Schmitz <>
To:	Jiri Kosina <>
Cc:	Geert Uytterhoeven <>,
	linux-m68k <>,
	Tejun Heo <>, Jens Axboe <>,
Subject: Re: Fwd: [PATCH] [RFC] ataflop: remove buggy IRQ disable from

Hi Jiri,

> > > Please elaborate a little bit more which of the two points above you base 
> > > your NACK on.
> > 
> > The removal of local_irq_disable() (which should have been local_irq_enable()) 
> > just raised a flag, and I didn't immediately see why the interrupt enable had 
> > been commented out. 
> Yes, it has been commented out in a very non-intuitive way.

That. too :-) What I meant to say - the reason why someone chose to comment out 
the original sti() wasn't really clear. I guess the reason for that particular 
change has been lost in the pre-git or bk era.
> > With a bit of further thought on the matter I am satisfied that this patch will 
> > not impact on driver function at all, and do not wish to sustain my objection.
> > 
> > IOW: Ack, and my sincere apologies for wasting your time. 
> Thanks, I have added
> 	Acked-by: Michael Schmitz <>
> to the patch changelog in my tree.

That's right ...


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists