lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-id: <alpine.DEB.2.00.0910200847320.8658@zirkon.biophys.uni-duesseldorf.de> Date: Tue, 20 Oct 2009 08:51:08 +0200 (CEST) From: Michael Schmitz <schmitz@...phys.uni-duesseldorf.de> To: Jiri Kosina <jkosina@...e.cz> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, linux-m68k <linux-m68k@...ts.linux-m68k.org>, Tejun Heo <tj@...nel.org>, Jens Axboe <jens.axboe@...cle.com>, linux-kernel@...r.kernel.org Subject: Re: Fwd: [PATCH] [RFC] ataflop: remove buggy IRQ disable from do_fd_request() Hi Jiri, > > > Please elaborate a little bit more which of the two points above you base > > > your NACK on. > > > > The removal of local_irq_disable() (which should have been local_irq_enable()) > > just raised a flag, and I didn't immediately see why the interrupt enable had > > been commented out. > > Yes, it has been commented out in a very non-intuitive way. That. too :-) What I meant to say - the reason why someone chose to comment out the original sti() wasn't really clear. I guess the reason for that particular change has been lost in the pre-git or bk era. > > With a bit of further thought on the matter I am satisfied that this patch will > > not impact on driver function at all, and do not wish to sustain my objection. > > > > IOW: Ack, and my sincere apologies for wasting your time. > > Thanks, I have added > > Acked-by: Michael Schmitz <schmitz@...phys.uni-duesseldorf.de> > > to the patch changelog in my tree. That's right ... Michael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists