linux-kernel - Re: [PATCH 2/2] rt2x00: Implement support for rt2800pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Oct 2009 08:58:54 +0200
From:	Holger Schurig <hs4233@...l.mn-solutions.de>
To:	Ivo van Doorn <ivdoorn@...il.com>
Cc:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	John Linville <linville@...driver.com>,
	linux-wireless@...r.kernel.org, users@...x00.serialmonkey.com,
	Alban Browaeys <prahal@...oo.com>,
	Benoit PAPILLAULT <benoit.papillault@...e.fr>,
	Felix Fietkau <nbd@...nwrt.org>,
	Luis Correia <luis.f.correia@...il.com>,
	Mattias Nissler <mattias.nissler@....de>,
	Mark Asselstine <asselsm@...il.com>,
	Xose Vazquez Perez <xose.vazquez@...il.com>,
	"linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] rt2x00: Implement support for rt2800pci

> I don't agree on this, for starters the whole "abstraction
> layer as done in the staging driver, really obfuscated the code
> in multiple areas 

Ivo, you could look at Orinoco or Libertas. Both WLAN drivers 
support a multitude of different hardware (Libertas: CF/PCMCIA, 
SDIO, SD, USB and Orinoco: CF/PCMCIA, PCI, PPC_PMAC). And both 
have hardware abstraction layers that don't suck, obfuscate or 
create lots of duplicate code.

So AFAIK it's not the question *IF* to do hardware abstraction 
but only a question *HOW* to do it in an intelligent way. Don't 
luck at one bad implementation and disregard the whole 
concept :-)

-- 
http://www.holgerschurig.de
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/