lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Oct 2009 10:18:02 -0400 From: Jeff Mahoney <jeffm@...e.com> To: Jiri Kosina <jkosina@...e.cz> Cc: Tejun Heo <tj@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghua.yu@...el.com>, linux-ia64@...r.kernel.org Subject: Re: Commit 34d76c41 causes linker errors on ia64 with NR_CPUS=4096 On 10/20/2009 02:27 AM, Jiri Kosina wrote: > @@ -1627,11 +1623,10 @@ static int tg_shares_up(struct task_group *tg, void *data) > return 0; > > local_irq_save(flags); > - usd = &__get_cpu_var(update_shares_data); > > for_each_cpu(i, sched_domain_span(sd)) { > weight = tg->cfs_rq[i]->load.weight; > - usd->rq_weight[i] = weight; > + usd = *per_cpu_ptr(update_shares_data, i) = weight; > > /* > * If there are currently no tasks on the cpu pretend there I don't think this is what you want here. In the original version, usd is the percpu var using the current cpu. In your version, usd is the percpu var using i instead of the current cpu. I'll post my version of the patch shortly. I don't think keeping most of the original version is a bad thing. We can just allocate it dynamically instead. -Jeff -- Jeff Mahoney SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists