lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Oct 2009 21:30:38 +0200 From: Roel Kluin <roel.kluin@...il.com> To: Andrew Morton <akpm@...ux-foundation.org>, linux-fbdev-devel@...ts.sourceforge.net, LKML <linux-kernel@...r.kernel.org> Subject: [PATCH] fbdev: Wrong test on unsigned in fb_set_user_cmap()? struct fb_cmap_user member start is unsigned. Signed-off-by: Roel Kluin <roel.kluin@...il.com> --- Is this required? diff --git a/drivers/video/fbcmap.c b/drivers/video/fbcmap.c index f53b9f1..f46f05f 100644 --- a/drivers/video/fbcmap.c +++ b/drivers/video/fbcmap.c @@ -266,7 +266,7 @@ int fb_set_user_cmap(struct fb_cmap_user *cmap, struct fb_info *info) rc = -ENODEV; goto out; } - if (cmap->start < 0 || (!info->fbops->fb_setcolreg && + if ((int)cmap->start < 0 || (!info->fbops->fb_setcolreg && !info->fbops->fb_setcmap)) { rc = -EINVAL; goto out1; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists