lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Oct 2009 14:56:53 -0700 From: David Daney <ddaney@...iumnetworks.com> To: Thomas Gleixner <tglx@...utronix.de> CC: Linus Walleij <linus.walleij@...ricsson.com>, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mips@...ux-mips.org, Mikael Pettersson <mikpe@...uu.se>, Ralf Baechle <ralf@...ux-mips.org> Subject: Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic Thomas Gleixner wrote: > On Sun, 18 Oct 2009, Linus Walleij wrote: >> This moves the clocksource_set_clock() and clockevent_set_clock() >> from the MIPS timer code into clockchips and clocksource where >> it belongs. The patch was triggered by code posted by Mikael >> Pettersson duplicating this code for the IOP ARM system. The >> function signatures where altered slightly to fit into their >> destination header files, unsigned int changed to u32 and inlined. >> >> Signed-off-by: Linus Walleij <linus.walleij@...ricsson.com> >> Cc: Thomas Gleixner <tglx@...utronix.de> >> Cc: Mikael Pettersson <mikpe@...uu.se> >> Cc: Ralf Baechle <ralf@...ux-mips.org> >> --- >> Ralf has stated in earlier conversation that this should be moved, >> now we risk duplicating code so let's move it. > > Please do not make that functions inline. They are too large and there > is no benefit of inlining them. > If that is the case, then perhaps they should not be defined in a header file. IMHO if you are defining a function in a header file it should always be 'static inline'. If you don't want it in-lined, put it in some library so we only pick up a single instance of it. David Daney -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists