linux-kernel - Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ADE3D3C.1070608@caviumnetworks.com>
Date:	Tue, 20 Oct 2009 15:44:12 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	Linus Walleij <linus.ml.walleij@...il.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mips@...ux-mips.org, Mikael Pettersson <mikpe@...uu.se>,
	Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code 
 generic

Linus Walleij wrote:
> 2009/10/20 David Daney <ddaney@...iumnetworks.com>:
> 
>>> Please do not make that functions inline. They are too large and there
>>> is no benefit of inlining them.
>> If that is the case, then perhaps they should not be defined in a header
>> file.
> 
> Of course not. There are apropriate places to put them, but as stated
> I think the use as it is today warrants having them inlined.
> 

I wasn't trying to imply that they shouldn't be inlined, only that if 
you  choose (as you did) to define them in a header file, that they 
*should* be inline.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/