linux-kernel - Re: [PATCH -tip perf/probes 0/2] x86 insn decoder bugfixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ADF2F6F.1040300@redhat.com>
Date:	Wed, 21 Oct 2009 11:57:35 -0400
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Frederic Weisbecker <fweisbec@...il.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Jim Keniston <jkenisto@...ibm.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	systemtap <systemtap@...rces.redhat.com>,
	DLE <dle-develop@...ts.sourceforge.net>
Subject: Re: [PATCH -tip perf/probes 0/2] x86 insn decoder bugfixes

Masami Hiramatsu wrote:
> Ingo Molnar wrote:
>>
>> there's still build failures:
>>
>>     TEST    posttest
>>    Error: ffffffff8103b917:        c5 59 fc ff             vpaddb %xmm7,%xmm4,%xmm15
>>    Error: objdump says 4 bytes, but insn_get_length() says 3 (attr:8000)
>>    make[1]: *** [posttest] Error 2
>>    make: *** [bzImage] Error 2
> 
> Aah, that's the AVX code...
> I assume, random-data-byte-sequence in the kernel binary
> contains it.

Hmm, I've found the actual code.

ffffffff81043917 <xen_sysret32_reloc>:
ffffffff81043917:       c5 59 fc ff             vpaddb %xmm7,%xmm4,%xmm15

---
ENTRY(xen_sysret32)
        /*
         * We're already on the usermode stack at this point, but
         * still with the kernel gs, so we can easily switch back
         */
        movq %rsp, PER_CPU_VAR(old_rsp)
        movq PER_CPU_VAR(kernel_stack), %rsp

        pushq $__USER32_DS
        pushq PER_CPU_VAR(old_rsp)
        pushq %r11
        pushq $__USER32_CS
        pushq %rcx

        pushq $VGCF_in_syscall
1:      jmp hypercall_iret
ENDPATCH(xen_sysret32)
RELOC(xen_sysret32, 1b+1)
---
#define RELOC(x, v)     .globl x##_reloc; x##_reloc=v
---

OK, it's not a random, but a data in kernel text.
Anyway, I'll add AVX support then.

Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/