linux-kernel - Re: [PATCH] exec: setup_arg_pages fails to return errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091021041444.GA5126@hallyn.com>
Date:	Tue, 20 Oct 2009 23:14:45 -0500
From:	"Serge E. Hallyn" <serge@...lyn.com>
To:	Anton Blanchard <anton@...ba.org>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] exec: setup_arg_pages fails to return errors

Quoting Anton Blanchard (anton@...ba.org):
> 
> In setup_arg_pages we work hard to assign a value to ret, but on exit
> we always return 0.
> 
> Also remove a now duplicated exit path and branch to out_unlock instead.
> 
> Signed-off-by: Anton Blanchard <anton@...ba.org>

Yikes!

Acked-by: Serge Hallyn <serue@...ibm.com>

> ---
> 
> Index: linux.trees.git/fs/exec.c
> ===================================================================
> --- linux.trees.git.orig/fs/exec.c	2009-09-28 12:17:10.000000000 +1000
> +++ linux.trees.git/fs/exec.c	2009-09-28 12:17:58.000000000 +1000
> @@ -624,10 +624,8 @@ int setup_arg_pages(struct linux_binprm 
>  	/* Move stack pages down in memory. */
>  	if (stack_shift) {
>  		ret = shift_arg_pages(vma, stack_shift);
> -		if (ret) {
> -			up_write(&mm->mmap_sem);
> -			return ret;
> -		}
> +		if (ret)
> +			goto out_unlock;
>  	}
>  
>  #ifdef CONFIG_STACK_GROWSUP
> @@ -641,7 +639,7 @@ int setup_arg_pages(struct linux_binprm 
>  
>  out_unlock:
>  	up_write(&mm->mmap_sem);
> -	return 0;
> +	return ret;
>  }
>  EXPORT_SYMBOL(setup_arg_pages);
>  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/