linux-kernel - Re: [RFC Patch] use MTRR for write combining if PAT is not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091021115259.GE16586@elte.hu>
Date:	Wed, 21 Oct 2009 13:52:59 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
Cc:	Thomas Schlichter <thomas.schlichter@....de>,
	Jan Beulich <JBeulich@...ell.com>,
	"arjan@...ux.intel.com" <arjan@...ux.intel.com>,
	"dri-devel@...ts.sourceforge.net" <dri-devel@...ts.sourceforge.net>,
	"hancockrwd@...il.com" <hancockrwd@...il.com>,
	"hmh@....eng.br" <hmh@....eng.br>, "hpa@...or.com" <hpa@...or.com>,
	"jbarnes@...tuousgeek.org" <jbarnes@...tuousgeek.org>,
	"jeremy.fitzhardinge@...rix.com" <jeremy.fitzhardinge@...rix.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"thellstrom@...are.com" <thellstrom@...are.com>,
	"tj@...nel.org" <tj@...nel.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"yinghai@...nel.org" <yinghai@...nel.org>
Subject: Re: [RFC Patch] use MTRR for write combining if PAT is not
	available


* Suresh Siddha <suresh.b.siddha@...el.com> wrote:

> On Tue, 2009-10-20 at 13:35 -0700, Thomas Schlichter wrote:
> > What do you think about the latest version of my patch series I just sent?
> 
> I think we can simplify this by just using mtrr_add_page() and avoid 
> all the complexity that comes with mtrr_add_unaligned().
> 
> pci_mmap_range() should call one mtrr_add_page() if the base and size 
> are nicely aligned. Almost all the cases, this is the usage sequence 
> here anyway.

yep, keeping it simple is a must.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/