linux-kernel - Re: Ordering problem in serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091022190142.0d7f35aa@lxorguk.ukuu.org.uk>
Date:	Thu, 22 Oct 2009 19:01:42 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Eugene Bordenkircher <eugebo@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Ordering problem in serial_core.c

> If the line discipline is throttling the port when close is called, it
> tries to unthrottle the port which, in the case of soft flow, tries to
> send the XON character.  This doesn't work well since at this point
> the uart has been shutdown.

A rather more relevant question is why is the serial driver doing an
ldisc flush in the first place. 

> The simple reordering shown below will seems to fix the problem, but
> please comment if there are other side effects I am not seeing.

I don't see one offhand, and it looks a reasonable fix. I'll take a
deeper look next week but it might not be a bad idea for this to get put
into -next to see.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/