linux-kernel - Re: spitz backlight: fix brightness limiting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1256251399.23211.164.camel@dax.rpnet.com>
Date:	Thu, 22 Oct 2009 23:43:19 +0100
From:	Richard Purdie <rpurdie@...ys.net>
To:	Eric Miao <eric.y.miao@...il.com>
Cc:	Pavel Machek <pavel@....cz>, Andrew Morton <akpm@...l.org>,
	lenz@...wisc.edu, kernel list <linux-kernel@...r.kernel.org>,
	Dirk@...er-online.de, arminlitzel@....de,
	Cyril Hrubis <metan@....cz>, thommycheck@...il.com,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	dbaryshkov@...il.com, omegamoon@...il.com, utx@...guin.cz
Subject: Re: spitz backlight: fix brightness limiting

On Thu, 2009-10-22 at 04:20 +0800, Eric Miao wrote:
> It's a little bit weird it's called 'limit_mask' when I first converted it
> to a spi driver. There must be some reasons, Richard, you've got
> any ideas?

Its a historical artifact that once worked through some bitfield magic
but probably stopped working when we increased the range of values the
backlight could accept and we didn't notice the limiting problem.

I'll happily take a patch to fix that.

Cheers,

Richard


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/