linux-kernel - Re: [RFC/PATCH] ratelimit: make output more useful

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091023145509.GA13793@elte.hu>
Date:	Fri, 23 Oct 2009 16:55:09 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Christian Borntraeger <borntraeger@...ibm.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dave Young <hidave.darkstar@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [RFC/PATCH] ratelimit: make output more useful


* Christian Borntraeger <borntraeger@...ibm.com> wrote:

> Index: tip/include/linux/kernel.h
> ===================================================================
> --- tip.orig/include/linux/kernel.h
> +++ tip/include/linux/kernel.h
> @@ -16,6 +16,7 @@
>  #include <linux/log2.h>
>  #include <linux/typecheck.h>
>  #include <linux/dynamic_debug.h>
> +#include <linux/ratelimit.h>
>  #include <asm/byteorder.h>
>  #include <asm/bug.h>
>  

hm, this will cause circular dependencies - see:

 3fff4c4: printk: Remove ratelimit.h from kernel.h

Any reason why it couldnt be pushed inside printk.c? We just need the 
func string - not the pointer pass-in. That would also address some of 
the call-site bloat.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/