lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Oct 2009 18:07:11 +0200 From: Pavel Machek <pavel@....cz> To: Arun R Bharadwaj <arun@...ux.vnet.ibm.com> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Ingo Molnar <mingo@...e.hu>, Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>, Dipankar Sarma <dipankar@...ibm.com>, Balbir Singh <balbir@...ibm.com>, Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-arch@...r.kernel.org, linux-acpi@...r.kernel.org Subject: Re: [v9 PATCH 4/9]: x86: refactor x86 idle power management code and remove all instances of pm_idle. On Fri 2009-10-16 15:13:08, Arun R Bharadwaj wrote: > * Arun R Bharadwaj <arun@...ux.vnet.ibm.com> [2009-10-16 15:08:50]: > > This patch cleans up x86 of all instances of pm_idle. > > pm_idle which was earlier called from cpu_idle() idle loop > is replaced by cpuidle_idle_call. > > x86 also registers to cpuidle when the idle routine is selected, > by populating the cpuidle_device data structure for each cpu. > > This is replicated for apm module and for xen, which also used pm_idle. > > > Signed-off-by: Arun R Bharadwaj <arun@...ux.vnet.ibm.com> > --- > arch/x86/kernel/apm_32.c | 55 ++++++++++++++++++++++++- > arch/x86/kernel/process.c | 90 ++++++++++++++++++++++++++++++++---------- > arch/x86/kernel/process_32.c | 3 - > arch/x86/kernel/process_64.c | 3 - > arch/x86/xen/setup.c | 40 ++++++++++++++++++ > drivers/acpi/processor_core.c | 9 ++-- > drivers/cpuidle/cpuidle.c | 16 +++++-- > 7 files changed, 182 insertions(+), 34 deletions(-) ... > +static int local_idle_loop(struct cpuidle_device *dev, struct cpuidle_state *st) > +{ > + ktime_t t1, t2; > + s64 diff; > + int ret; > + > + t1 = ktime_get(); > + local_idle(); > + t2 = ktime_get(); > + > + diff = ktime_to_us(ktime_sub(t2, t1)); > + if (diff > INT_MAX) > + diff = INT_MAX; > + ret = (int) diff; > + > + return ret; > +} So we get this routine essentially 3 times. Is there no way to share the code? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists