linux-kernel - RE: [PATCH] Fix null pointer error after vmbus loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1FB5E1D5CA062146B38059374562DF72180B430B@TK5EX14MBXC126.redmond.corp.microsoft.com>
Date:	Fri, 23 Oct 2009 16:22:26 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	Greg KH <gregkh@...e.de>
CC:	Hank Janssen <hjanssen@...rosoft.com>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Fix null pointer error after vmbus loading

> -----Original Message-----
> From: Greg KH [mailto:gregkh@...e.de]
> But this is not how you check to see if your device is registered at
> all, you can not rely on the driver core to have the name set or not to
> reflect the status of the device.  Devices have many stages in their
> lifecycle, and the name reliably shows none of them.
> 
> Actually, why do you need to know this?  Shouldn't you always know the
> state of your device, how can you get passed an unregistered device?

I have traced down the callers to the function, vmbus_child_device_register(),
and verified that the struct device was kzalloc-ed by the current thread,
and not visible to other threads before we register the device. So the 
dev name is always NULL here, we can skip the NULL & strlen checking. I 
will send you the new patch soon.

Thanks,

- Haiyang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/