linux-kernel - Re: spitz backlight: fix brightness limiting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f17812d70910230056y3d1fca0enc821f9ef46f07145@mail.gmail.com>
Date:	Fri, 23 Oct 2009 15:56:59 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Richard Purdie <rpurdie@...ys.net>, Andrew Morton <akpm@...l.org>,
	lenz@...wisc.edu, kernel list <linux-kernel@...r.kernel.org>,
	Dirk@...er-online.de, arminlitzel@....de,
	Cyril Hrubis <metan@....cz>, thommycheck@...il.com,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	dbaryshkov@...il.com, omegamoon@...il.com, utx@...guin.cz
Subject: Re: spitz backlight: fix brightness limiting

On Fri, Oct 23, 2009 at 1:20 PM, Pavel Machek <pavel@....cz> wrote:
> On Thu 2009-10-22 23:43:19, Richard Purdie wrote:
>> On Thu, 2009-10-22 at 04:20 +0800, Eric Miao wrote:
>> > It's a little bit weird it's called 'limit_mask' when I first converted it
>> > to a spi driver. There must be some reasons, Richard, you've got
>> > any ideas?
>>
>> Its a historical artifact that once worked through some bitfield magic
>> but probably stopped working when we increased the range of values the
>> backlight could accept and we didn't notice the limiting problem.
>>
>> I'll happily take a patch to fix that.
>
> Patch is available in the parent post. For now, I just fix it so that
> it does not turn backlight off when it should not. I'll submit
> limit_mask -> limit as separate patch, ok?

I'm fine with that. Feel free to.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/