linux-kernel - Re: [PATCH 6/9] ser_gigaset: checkpatch cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091025203705.273e1c14@lxorguk.ukuu.org.uk>
Date:	Sun, 25 Oct 2009 20:37:05 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Tilman Schmidt <tilman@...p.cc>
Cc:	David Miller <davem@...emloft.net>,
	Karsten Keil <isdn@...ux-pingi.de>,
	Hansjoerg Lipp <hjlipp@....de>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, isdn4linux@...tserv.isdn4linux.de,
	i4ldeveloper@...tserv.isdn4linux.de
Subject: Re: [PATCH 6/9] ser_gigaset: checkpatch cleanup

On Sun, 25 Oct 2009 20:30:27 +0100 (CET)
Tilman Schmidt <tilman@...p.cc> wrote:

> Duly uglified as demanded by checkpatch.pl.
> 
> Impact: cosmeti

Umm ??

> -		if (!(bcs->tx_skb = skb_dequeue(&bcs->squeue)))
> +		nextskb = skb_dequeue(&bcs->squeue);
> +		if (!nextskb)
>  			/* no skb either, nothing to do */
>  			return;
> +		bcs->tx_skb = nextskb;

This does not do the same thing as before

Previously the NULL case assigned to bcs->tx_skb, now it does not.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/