linux-kernel - Re: [PATCH 0/7] kfifo: new API v0.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091025014831.GC32470@one.firstfloor.org>
Date:	Sun, 25 Oct 2009 02:48:31 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Stefani Seibold <stefani@...bold.net>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	Andi Kleen <andi@...stfloor.org>,
	Amerigo Wang <xiyou.wangcong@...il.com>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 0/7] kfifo: new API v0.6

On Sat, Oct 24, 2009 at 03:33:14PM +0200, Stefani Seibold wrote:
> This is a new generic kernel FIFO implementation.
> 
> The current kernel fifo API is not very widely used, because it has to many
> constrains. Only 17 files in the current 2.6.31-rc5 used it. FIFO's are
> like list's a very basic thing and a kfifo API which handles the most use
> case would save a lot of development time and memory resources.
> 
> I think this are the reasons why kfifo is not in use:
> 
> - The API is to simple, important functions are missing
> - A fifo can be only allocated dynamically
> - There is a need of a spinlock despite you need it or not
> - There is no support for data records inside a fifo

I have some plans to use this kfifo code in upcoming code (mostly
as a very simple lower overhead NMI safe per CPU fifo). I would appreciate 
if it could be merged ASAP

I didn't review this iteration, but earlier ones.

Acked-by: Andi Kleen <ak@...ux.intel.com>

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/