linux-kernel - Re: [PATCH] ext2: Avoid WARN() messages when failing to write to the superblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091025062128.GA1391@ucw.cz>
Date:	Sun, 25 Oct 2009 07:21:28 +0100
From:	Pavel Machek <pavel@....cz>
To:	Theodore Ts'o <tytso@....edu>
Cc:	Linux Kernel Developers List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ext2: Avoid WARN() messages when failing to write to
	the superblock

On Tue 2009-10-20 01:22:26, Theodore Ts'o wrote:
> This fixes a common warning reported by kerneloops.org
> 

> +static void ext2_clear_super_error(struct super_block * sb)
> +{
> +	struct buffer_head *sbh = EXT2_SB(sb)->s_sbh;
> +
> +	if (buffer_write_io_error(sbh)) {
> +		/*
> +		 * Oh, dear.  A previous attempt to write the
> +		 * superblock failed.  This could happen because the
> +		 * USB device was yanked out.  Or it could happen to
> +		 * be a transient write error and maybe the block will
> +		 * be remapped.  Nothing we can do but to retry the
> +		 * write and hope for the best.
> +		 */
> +		printk(KERN_ERR "EXT2-fs: %s previous I/O error to "
> +		       "superblock detected", sb->s_id);

KERN_ALERT/KERN_CRITICAL?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/