linux-kernel - Re: checkpatch is not detecting bad whitespacing when using macros on formulas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091026112036.GG12089@shadowen.org>
Date:	Mon, 26 Oct 2009 11:20:36 +0000
From:	Andy Whitcroft <apw@...onical.com>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Andy Walls <awalls@...ix.net>
Subject: Re: checkpatch is not detecting bad whitespacing when using macros
 on formulas

On Sun, Oct 11, 2009 at 07:19:11AM -0300, Mauro Carvalho Chehab wrote:
> Hi Andy Whitcroft,
> 
> While reviewing a patch from Andy Walls, I noticed that checkpatch v 0.29
> didn't get any errors when bad whitespacing is used on some formulas:
> 
> $ checkpatch.pl cx23888-ir-part2_2.patch
> total: 0 errors, 0 warnings, 1237 lines checked
> 
> cx23888-ir-part2_2.patch has no obvious style problems and is ready for submission.
> 
> However, there are several places at the patch like:
> 
> +static inline u16 ns_to_clock_divider(unsigned int ns)
> +{
> +       return count_to_clock_divider(
> +                 DIV_ROUND_CLOSEST(CX23888_IR_REFCLK_FREQ/1000000 * ns, 1000));
> +}

I assume the error you are pointing out is the lack of spacing round the
divide operator.  Though the guidelines ask for spacing on both sides
there are cases where it has been argued that no spacing is more
appropriate.  Once such case is where the expression is effectivly
generating a constant, such as that above and you will find a slew of
such uses in the kernel.  As a result the checkpatch check for this
spacing is actually slightly more liberal checking for consistant
spacing on either side, spaces both sides or neither.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/