linux-kernel - Re: [RFC V2 PATCH 5/5] cfq-iosched: fairness for sync no-idle queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49k4yixiox.fsf@segfault.boston.devel.redhat.com>
Date:	Mon, 26 Oct 2009 11:45:34 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Corrado Zoccolo <czoccolo@...il.com>
Cc:	"Linux-Kernel" <linux-kernel@...r.kernel.org>,
	Jens Axboe <jens.axboe@...cle.com>
Subject: Re: [RFC V2 PATCH 5/5] cfq-iosched: fairness for sync no-idle queues

Corrado Zoccolo <czoccolo@...il.com> writes:

> +static enum wl_type_t cfqq_type(struct cfq_queue *cfqq)
> +{
> +	if (!cfq_cfqq_sync(cfqq))
> +		return ASYNC_WORKLOAD;
> +	if (CFQQ_SEEKY(cfqq) || !cfq_cfqq_idle_window(cfqq))
> +		return SYNC_NOIDLE_WORKLOAD;
> +	return SYNC_WORKLOAD;
> +}

The calculation to determine whether or not to idle is now done in at
least 2 places.  Perhaps it's time for a helper function.

There are some other coding style nits, but I'll let Jens comment on
those.  I think the idea looks good.  Once you rebase I'll run some
tests; this is some really good work!

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/