lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 26 Oct 2009 11:45:34 -0400
From:	Jeff Moyer <>
To:	Corrado Zoccolo <>
Cc:	"Linux-Kernel" <>,
	Jens Axboe <>
Subject: Re: [RFC V2 PATCH 5/5] cfq-iosched: fairness for sync no-idle queues

Corrado Zoccolo <> writes:

> +static enum wl_type_t cfqq_type(struct cfq_queue *cfqq)
> +{
> +	if (!cfq_cfqq_sync(cfqq))
> +		return ASYNC_WORKLOAD;
> +	if (CFQQ_SEEKY(cfqq) || !cfq_cfqq_idle_window(cfqq))
> +	return SYNC_WORKLOAD;
> +}

The calculation to determine whether or not to idle is now done in at
least 2 places.  Perhaps it's time for a helper function.

There are some other coding style nits, but I'll let Jens comment on
those.  I think the idea looks good.  Once you rebase I'll run some
tests; this is some really good work!

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists