linux-kernel - Re: [PATCH] 2.6.32-rc5 bug in Palm Tungsten C keyboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Oct 2009 15:43:44 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Ondrej Zajicek <santiago@...reenet.org>
Cc:	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	marek.vasut@...il.com
Subject: Re: [PATCH] 2.6.32-rc5 bug in Palm Tungsten C keyboard

On Tue, Oct 27, 2009 at 6:59 AM, Ondrej Zajicek <santiago@...reenet.org> wrote:
> Palm Tungsten C keyboard structure has swapped
> rows/cols gpio structures and does not work.
> This patch fixes it.
>
> Signed-off-by: Ondrej Zajicek <santiago@...reenet.org>

This fix looks obvious to me. Applied to 'fix'.

>
> diff -uprN linux-2.6.32-rc5-old/arch/arm/mach-pxa/palmtc.c linux-2.6.32-rc5/arch/arm/mach-pxa/palmtc.c
> --- linux-2.6.32-rc5-old/arch/arm/mach-pxa/palmtc.c     2009-10-16 02:41:50.000000000 +0200
> +++ linux-2.6.32-rc5/arch/arm/mach-pxa/palmtc.c 2009-10-26 20:56:44.000000000 +0100
> @@ -292,10 +292,10 @@ const static unsigned int palmtc_keypad_
>
>  static struct matrix_keypad_platform_data palmtc_keypad_platform_data = {
>        .keymap_data    = &palmtc_keymap_data,
> -       .col_gpios      = palmtc_keypad_row_gpios,
> -       .num_col_gpios  = 12,
> -       .row_gpios      = palmtc_keypad_col_gpios,
> -       .num_row_gpios  = 4,
> +       .row_gpios      = palmtc_keypad_row_gpios,
> +       .num_row_gpios  = ARRAY_SIZE(palmtc_keypad_row_gpios),
> +       .col_gpios      = palmtc_keypad_col_gpios,
> +       .num_col_gpios  = ARRAY_SIZE(palmtc_keypad_col_gpios),
>        .active_low     = 1,
>
>        .debounce_ms            = 20,
>
>
> --
> Elen sila lumenn' omentielvo
>
> Ondrej 'SanTiago' Zajicek (email: santiago@...reenet.org)
> OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
> "To err is human -- to blame it on a computer is even more so."
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/