lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 27 Oct 2009 09:47:32 +0000
From:	"Jan Beulich" <>
To:	"FUJITA Tomonori" <>
Cc:	<>, <>, <>,
	<>, <>,
	<>, <>
Subject: Re: [PATCH] x86: adjust GFP mask handling for coherent

>>> FUJITA Tomonori <> 27.10.09 10:37 >>>
>On Tue, 27 Oct 2009 09:23:38 +0000
>"Jan Beulich" <> wrote:
>> Because there's quite a few of them - just search for callers of
>> dma_alloc_coherent() passing NULL as the first argument. Of course
>> I'd rather see the fallback gone, but I think this requires cooperation
>> from/action taken by the driver maintainers first. A first step might be
>> to add a WRN_ON() for that case, but I don't see it being reasonable
>> to eliminate the fallback right away. Hence, with it having got broken
>> in .26 I think it is reasonable to fix it for the time being.
>Well, the most of them are drivers that nobody cares about (uses).
>What drivers did you hit this problem with?

drivers/firmware/dell_rbu.c (on .27.x, and in particular with the derivation
of __GFP_NORETRY from __GFP_DMA, which fortunately doesn't exist in
newer kernels anymore).

>We've lived with the current code for some years so this problem isn't
>urgent at all. Please don't add another workaround for broken code.
>Let's put WARN_ON for callers that use NULL and see who complains.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists