linux-kernel - Re: [PATCH ide] : Increase WAIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AE6CA70.3000002@ru.mvista.com>
Date:	Tue, 27 Oct 2009 13:24:48 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Philippe De Muyter <phdm@...qel.be>
Cc:	David Miller <davem@...emloft.net>, hancockrwd@...il.com,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH ide] : Increase WAIT_DRQ to support slow CF cards

Hello.

Philippe De Muyter wrote:

>> From: Robert Hancock <hancockrwd@...il.com>
>> Date: Mon, 26 Oct 2009 19:40:03 -0600
>>
>>     
>>> On Mon, Oct 26, 2009 at 7:19 PM, David Miller <davem@...emloft.net> wrote:
>>>       
>>>> Meanwhile we should provide a way for things to work, and
>>>> realistically the only way to do that currently is to bump the
>>>> WAIT_DRQ value to some large number.
>>>>
>>>> And that's exactly the kind of patch I'm willing to accept for this.
>>>>         
>>> I agree, it's sub-optimal but it helps.. if the user wants better
>>> behavior they should a) fix it so that the card isn't using PIO, at
>>> least if it supports DMA and b) not use drivers/ide..
>>>       
>
> Strangely enough, I also had no timeout problem if I started my kernel with
> 'ide=nodma', instead of increasing WAIT_DRQ.

    Hm, interesting...

>  So I surmise that WAIT_DRQ is used in the dma case.
>
>   

   It's used only for the PIO write commands -- see do_rw_taskfile() in 
ide-taskfile.c... DMA commands don't require waiting for BSY=0, DRQ=1 
condition.

> Philippe
>   

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/