linux-kernel - Re: [PATCH]kernel/irq/chip.c:The code notes is not fit for the function.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Oct 2009 13:53:40 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	liu weni <qingshenlwy@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]kernel/irq/chip.c:The code notes is not fit for the
 function.

On Mon, 26 Oct 2009, liu weni wrote:

> In the origin, the code notes are not fit for set_irq_msi.
> I modify the code notes, and no any changes for the code.
> 
> 
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index c166019..da2f254 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
>  EXPORT_SYMBOL(set_irq_data);
> 
>  /**
> - * set_irq_data - set irq type data for an irq
> + * set_irq_msi - set MSI descriptor data for an irq
>   * @irq: Interrupt number
>   * @entry: Pointer to MSI descriptor data
>   *
> - * Set the hardware irq controller data for an irq
> + * Set the MSI descriptor entry for an irq
>   */
>  int set_irq_msi(unsigned int irq, struct msi_desc *entry)
>  {

Please send the patch with proper Signed-off-by: line so that I can queue 
it in my tree.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.