lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 27 Oct 2009 08:43:21 +0800
From:	Huang Ying <ying.huang@...el.com>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	Andrew Patterson <andrew.patterson@...com>,
	"prarit@...hat.com" <prarit@...hat.com>,
	"andi@...stfloor.org" <andi@...stfloor.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"pci-linux@...r.kernel.org" <pci-linux@...r.kernel.org>
Subject: Re: [PATCH 5/5] PCI: fix memory leak in aer_inject

Hi, Jesse,

On Tue, 2009-10-27 at 05:21 +0800, Jesse Barnes wrote: 
> On Mon, 12 Oct 2009 15:44:30 +0800
> Huang Ying <ying.huang@...el.com> wrote:
> 
> > On Mon, 2009-10-12 at 15:03 +0800, Andrew Patterson wrote: 
> > > PCI: fix memory leak in aer_inject
> > > 
> > > Fixed probable typo in aer_inject cleanup code resulting in a memory
> > > leak.
> > > 
> > > Signed-off-by: Andrew Patterson <andrew.patterson@...com>
> > > ---
> > > 
> > > diff --git a/drivers/pci/pcie/aer/aer_inject.c
> > > b/drivers/pci/pcie/aer/aer_inject.c index da2ad6e..2246bf7 100644
> > > --- a/drivers/pci/pcie/aer/aer_inject.c
> > > +++ b/drivers/pci/pcie/aer/aer_inject.c
> > > @@ -474,7 +474,7 @@ static void __exit aer_inject_exit(void)
> > >  	}
> > >  
> > >  	spin_lock_irqsave(&inject_lock, flags);
> > > -	list_for_each_entry_safe(err, err_next, &pci_bus_ops_list,
> > > list) {
> > > +	list_for_each_entry_safe(err, err_next, &einjected, list) {
> > >  		list_del(&err->list);
> > >  		kfree(err);
> > >  	}
> > 
> > Thanks for the patch.
> > 
> > Acked-by: Huang Ying <ying.huang@...el.com>
> > 
> 
> How do the rest of the patches look, Ying?  Should I add your acked-by
> on Andrew's latest set?

The whole latest patchset looks good to me.

Acked-by: Huang Ying <ying.huang@...el.com>

Best Regards,
Huang Ying


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists