lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Oct 2009 08:24:57 -0700 From: Mike Travis <travis@....com> To: Andi Kleen <andi@...stfloor.org> CC: Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>, Andrew Morton <akpm@...ux-foundation.org>, Jack Steiner <steiner@....com>, "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org, David Rientjes <rientjes@...gle.com>, Yinghai Lu <yinghai@...nel.org>, Mel Gorman <mel@....ul.ie>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/8] SGI x86_64 UV: Limit the number of number of SRAT messages Andi Kleen wrote: > Mike Travis <travis@....com> writes: > >> Limit number of SRAT messages of the form: >> [ 0.000000] SRAT: PXM 0 -> APIC 0 -> Node 0 > > While I generally agree on the concept of limiting per CPU information > (see other mail) I don't think removing this message by default > is a good idea. I regularly needed it for debugging some NUMA related > problems and they still happen moderately often even today. > > I think the right approach here, to limit output, would be to figure out > a more compact output format, perhaps using a matrix in a table > or simply printing multiple pair per line. > > -Andi > In this approach, I only print the first SRAT of each node... Is this closer to what you're looking for? Thanks, Mike SGI x86_64 UV: Limit the number of number of SRAT messages Limit number of SRAT messages of the form: [ 0.000000] SRAT: PXM 0 -> APIC 0 -> Node 0 Cc: H. Peter Anvin <hpa@...or.com> Cc: x86@...nel.org Cc: David Rientjes <rientjes@...gle.com> Cc: Yinghai Lu <yinghai@...nel.org> Cc: Mel Gorman <mel@....ul.ie> Cc: linux-kernel@...r.kernel.org Signed-off-by: Mike Travis <travis@....com> --- arch/x86/mm/srat_64.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) --- linux.orig/arch/x86/mm/srat_64.c +++ linux/arch/x86/mm/srat_64.c @@ -115,6 +115,7 @@ { int pxm, node; int apic_id; + static int last_node = -1; if (srat_disabled()) return; @@ -136,8 +137,11 @@ apicid_to_node[apic_id] = node; node_set(node, cpu_nodes_parsed); acpi_numa = 1; - printk(KERN_INFO "SRAT: PXM %u -> APIC %u -> Node %u\n", - pxm, apic_id, node); + if (node > last_node) { + printk(KERN_INFO "SRAT: PXM %u -> APIC %u -> Node %u\n", + pxm, apic_id, node); + last_node = node; + } } /* Callback for Proximity Domain -> LAPIC mapping */ @@ -146,6 +150,7 @@ { int pxm, node; int apic_id; + static int last_node = -1; if (srat_disabled()) return; @@ -170,8 +175,11 @@ apicid_to_node[apic_id] = node; node_set(node, cpu_nodes_parsed); acpi_numa = 1; - printk(KERN_INFO "SRAT: PXM %u -> APIC %u -> Node %u\n", - pxm, apic_id, node); + if (node > last_node) { + printk(KERN_INFO "SRAT: PXM %u -> APIC %u -> Node %u\n", + pxm, apic_id, node); + last_node = node; + } } #ifdef CONFIG_MEMORY_HOTPLUG_SPARSE -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists