linux-kernel - Re: [RFC] to rebase or not to rebase on linux-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Oct 2009 14:07:18 -0400
From:	Theodore Tso <tytso@....edu>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	"Luck, Tony" <tony.luck@...el.com>, Ingo Molnar <mingo@...e.hu>,
	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Nicolas Pitre <nico@...xnic.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"Luis R. Rodriguez" <mcgrof@...il.com>,
	Jeff Garzik <jeff@...zik.org>,
	Robert Richter <robert.richter@....com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jean Delvare <khali@...ux-fr.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [RFC] to rebase or not to rebase on linux-next

On Mon, Oct 26, 2009 at 07:01:57PM +0100, Stefan Richter wrote:
> > Suppose I update the 40th patch of a 50th patch series to add check
> > for kmalloc() returning NULL that had been inadvertently left out, or
> > some other error checking is added.  Or suppose I add a new tracepoint
> > definition to a 50 patch series.
> 
> ...are bad examples in the context of linux-next, IMO.  A missing
> allocation failure check or a missing tracepoint don't break
> bisectability.  So why discard this history?  (It was already published
> in a release preview.)

There are multiple issues for rewinding patches.  One is to avoid
breaking bisectability.  Other is to keep related changes in
functionality in a single place.  2-3 years for now, does anyone
really care about retaining development history?  In the human memory,
one of the most important parts of long-term memory formation is
*forgetting*; that is, editing down everything that happened down to
the most cogent and importants bits of history.  This is what is
disrupted when people don't get enough sleep.

Similarly, there is absolutely no point in preserving the v1, v2, v3,
v4... versions of patches that appeared in LKML in Linus's git tree
--- surely people agree that's true?  And if something is being
maintained in quilt, and there are v1, v2, v3, v4 versions of a patch,
there's no reason why we should put it in git, right?  So if it's in a
rewinding git branch, such as what happens in the pu branch in git
development, the history isn't preserved either ---- and that's O.K.

	     	 	       		 	- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/