linux-kernel - Re: [RFC] to rebase or not to rebase on linux-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0910271200060.31845@localhost.localdomain>
Date:	Tue, 27 Oct 2009 12:06:03 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
cc:	Theodore Tso <tytso@....edu>, Ingo Molnar <mingo@...e.hu>,
	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Nicolas Pitre <nico@...xnic.net>,
	"Luck, Tony" <tony.luck@...el.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"Luis R. Rodriguez" <mcgrof@...il.com>,
	Jeff Garzik <jeff@...zik.org>,
	Robert Richter <robert.richter@....com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jean Delvare <khali@...ux-fr.org>,
	Sam Ravnborg <sam@...nborg.org>
Subject: Re: [RFC] to rebase or not to rebase on linux-next

On Sat, 24 Oct 2009, Stefan Richter wrote:
> 
> Per linux-next submission rules, all /essential/ credits are already
> present.  But I agree that it is worth rewinding a for-next branch in
> order to add (non-essential) credits later.

I'd actually personally prefer that people do _not_ generally add 
"credits" later.

Quite frankly, if something was committed without having been ack'ed by 
some person, then later - when that person sees it on a commit list, for 
example - it's worthless adding somebodys late ack.

Same largely goes for 'tested-by' lines. 

And 'signed-off-by' are actively _wrong_ to add later. If it didn't come 
with a sign-off in the first place, it shouldn't have been committed.

One reason I say this is that I really think it's wrong to even give 
credit to some late-comer that pipes in after the patch has already made 
it into somebody's tree. If they didn't comment on it while it was passed 
around as a patch on mailing lists, what's the point? By the time it's in 
somebody elses published tree, any "ack" is worthless, and that person 
should simply _not_ get credit for being late to the party.

So I think that there are many good reasons to rebase patches in your own 
tree, but I do _not_ think that "adding late acks" is one such reason. If 
you've published your tree to others, then it's done. Don't lie about 
getting an ack that you didn't get before you made that patch public.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/