linux-kernel - Re: [PATCH 9/9] tracing: recordmcount.pl Remove the redundant code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1256676701.26028.465.camel@gandalf.stny.rr.com>
Date:	Tue, 27 Oct 2009 16:51:41 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Li Hong <lihong.hi@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 9/9] tracing: recordmcount.pl Remove the redundant code

On Tue, 2009-10-27 at 15:05 +0800, Li Hong wrote:
> >From d0aa71d523b6315fd3ea0ee66fddb020a625856f Mon Sep 17 00:00:00 2001
> From: Li Hong <lihong.hi@...il.com>
> Date: Tue, 27 Oct 2009 13:28:53 +0800
> Subject: [PATCH] tracing: recordmcount.pl Remove the redundant code
> 
> If an object file has some local symbols and objcopy doesn't support local
> reference, we have exited before the real work starts. So remove the redundant
> check in update_funcs.

Are you sure? Where does it exit? Even if I add patch 6, you can still
have a section that does not have any globals in it.

-- Steve

> 
> Signed-off-by: Li Hong <lihong.hi@...il.com>
> 
> diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
> index 867c24a..ff3a9eb 100755
> --- a/scripts/recordmcount.pl
> +++ b/scripts/recordmcount.pl
> @@ -353,14 +353,7 @@ sub update_funcs
>      return unless ($ref_func and @offsets);
>  
>      # is this function static? If so, note this fact.
> -    if (defined $locals{$ref_func}) {
> -
> -	# only use locals if objcopy supports globalize-symbols
> -	if (!$can_use_local) {
> -	    return;
> -	}
> -	$convert{$ref_func} = 1;
> -    }
> +    $convert{$ref_func} = 1 if $locals{$ref_func}; 
>  
>      # Loop through all the mcount caller offsets and print a reference
>      # to the caller based from the ref_func.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/